Robert Osfield wrote: > I've applied your changes to osgconv.cpp, but as I have rejected to > the suffix changes to ProxyNode and PagedLOD this own't compile
Ok. We'll try to get that sorted out then. > This change does raise the issue of how to implement the functionality > that you are after. Could you explain at high level what you are > after here. We can then start the process of working out how most > efficiently to implement it. I am unclear which functionality you're asking about here -- the suffix, or the overall osgconv recursion capability? > As a general notes, in future submissions could you adopt a little > more line spacing in you code, as it's density makes it harder to read > and understand, also the comment in between add little when the > variable and method names tell the same story. Sorry. I'm somewhat caught between multiple coding styles. I'll try to lean towards OSG's style more in this regard. > The OSG also uses a > convention of variable names always beginning with a lower, and class > names beginning with a Captial, this helps one know at a glance if > it's a class or a variable that you are looking at. If you mix > variable names like Node or ChildLoop into the code it starts to get > confusing, and in the case of Node it even offers the opportunity for > osg::Node and the variable getting mixed up by the compiler. Yes, I've been trying to follow OSG's camelCase here, but I slip up at times as you've seen. Thanks for catching those, and I'll try not to let them through in the future. > As things stand I'll need to tweak the code to fit with the usual > variable naming style otherwise other OSG users will start getting > confused about what is going on and what is the official naming > convention. Ok. If you can clarify what exactly you were asking for an explanation of above, we can probably get this sorted out. > Cheers, > Robert. -- Chris 'Xenon' Hanson, omo sanza lettere Xenon AlphaPixel.com PixelSense Landsat processing now available! http://www.alphapixel.com/demos/ "There is no Truth. There is only Perception. To Perceive is to Exist." - Xen _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
