Hi Ulrich, For now I've just merged the change from init() to _init() as this a bug fix.
The vsync enable/disable I'll merged next, but right now I have family life to get on with. W.r.t SCOPE local variable definition, I believe this will lead to warnings about an unused variable when the OSG is built with notification disabled. Perhaps a local #define would do the trick on providing the local SCOPE. Personally though I'm not sure even adding this extra variable is really much of step forward, it's just adding complexity to save a few characters in each notify message. Cheers, Robert. On Sat, Mar 20, 2010 at 7:18 AM, Ulrich Hertlein <[email protected]> wrote: > Hi Robert, > > please find attached patches that allow runtime toggling of sync-to-vblank. > It's > currently only implemented and tested on OS X, with an untested stub on Win32. > > The vsync code attempts to follow the setting in the _traits object. However > this > currently means that it won't work if no traits have been specified. I'd > like to change > this so that GraphicsWindow has an internal bool that contains the current > vsync state and > the traits are only used to initialise this value. > > The StatsHandler has a new key 'v' that toggles it on/off. > > This also contains a fix for the bug I reported on osg-users: > - the init() call was changed to _init() > - private bool _initialized now has a protected getter > > Cheers, > /ulrich > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
