Hi Ulrich, On Wed, Apr 21, 2010 at 5:55 PM, Robert Osfield <[email protected]> wrote: > I've just doing the review of your changes and so far most likely look > great, but one part I'm not 100% sure about is that your've got lines > that call wglSwapIntervalEXT() without any compile-time/run-time > guards to make sure that it's available. Is it available on all > graphics cards and drivers and headers?
I've just looked at Chris's changes to GraphicsWindowWin32.cpp, these put the wglSwapIntervalEXT() call into the realizeImplementation() so don't overlap with yours, but they also do check to the existance of wglSwapIntervalEXT() to his code could provide a template of what should be done. What I'll do is merge all your changes but #if 0 out the potentially problematic wglSwapIntervalEXT() call. I'll also copy over Chris's changes into GraphicsWindowWin32.cpp and add a call to GraphicsWindowWin32::setSyncToVBlank(bool) into the realizeImplementation() in place of Chris's original calls to wglSwapIntervalEXT(). I won't be able to compile test it though, but once it's checked it hopefully yourself and Chris can check my changes out and then remove the #if 0 and make sure it's working fine and then re-submit this to me in a form that we know works. I'll see if I can complete that this evening. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
