Hi Robert,
briefly:
- DEFAULT_SETTTINGS is a good idea
- Trackball rotation speed independent on FPS - definitely useful
- changing Vec3d to Vec3 is ok for me. This came to my mind in the final
code review as well.
- FlightManipulator - ?
- DriveManipulator - ?
DriveManipulator does not contain the bug as I did not had no more time
left to convert the manipulator to the "new" architecture.
FlightManipulator contains the problem, however, I will follow your
suggestion and wait for your tweaks to be checked in.
I will at least fix the FlightManipulator problem, but feel free to
provide more ideas.
John
Robert Osfield wrote:
Hi John,
On Tue, May 25, 2010 at 11:01 AM, Robert Osfield
<[email protected]> wrote:
Another regression (w.r.t svn/trunk at least) is that the trackball
had been updated so that it's throw speed didn't change with the frame
rate. I'm going to revert to svn/trunk to just double check this.
I've now compared to trunk version of TrackballManipulator and found
that indeed the throw issue with vsync off has been fixed, this
requires some extra frame delete member variables and associated code
to be added, and in the case of your changes this will be to
StandardManipulator. I'm currently added the timing code, but in
terms of the throw speed I haven't yet worked out where in the new
classes I should be added this. Leave this to me as it'll be a good
exercise for me to learn about what you've done.
My current plan is to do my local changes to fix some of the API
(introducing Vec3d in place of your use Vec3's) and the introduce the
new DEFAULT_SETTINGS, and the new frame timing code required to
produce smoother throw animations when vysnc is off or the frame rate
is low. Once I've made these changes I'll merge them with svn/trunk.
There will still be work to do, but it will at least give us a common
base to work on. At your end I'd suggest waiting till I've checked in
my tweaks to your code before you do any further work.
Cheers,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
