Not a problem. I will adjust it. BTW: Its not me who developed this idea
and I learned it at University of Twente (NL) as they are using it.
You are right, one coding style is important. At least I will look once
again for missing doc, etc. My suggestion is also to consider to require
doc for all new OSG submitted code. Code without doc is somehow not
complete submission because someone else has to read the code and write
it later. Maybe, the word "require" is too strong here. Anyway, just an
idea.
Will be back at the end of week with FlightManipulator, indentation, and
one small compile fix for Fedora.
John
Robert Osfield wrote:
Hi John,
When reviewing the code I noticed that all the files you've written or
modified have a 3 space indentation in them. I can't get my head
around why on earth you'd want to use a odd number like 3 spaces. The
OSG uses 4 spaces as this is the most common and the most portable
spacing to use across OS's and dev tools.
I can't let the OSG drift off into some mess of coding styles so have
had to by hand go through all your files and fix them to adhere more
closely to the standard coding style that the OSG users. This has is
not a quick job, and one that does progress any features or bug fixes,
so it's darn frustrating to have to do it.
Could please in future adopt the coding style of the OSG when
submitting code as it's a real waste of my time having to fix it.
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
