Hi,
On 26/05/10 09:51, Robert Osfield wrote:
Hi J.P,
I have I tried a range of indentation tools but they all work poorly
for C++. Perhaps indent has improved since I last tried it but in the
past I've poor far more time into trying to get these tools to work
well enough to use than just fixing stuff by hand. You always have to
review the code afterwards too to make sure that the tool doesn't
screw up.
yes, I agree, there's no magic pain relief for it.
jp
Robert.
On Wed, May 26, 2010 at 8:02 AM, J.P. Delport<[email protected]> wrote:
Hi Robert,
sorry to chip in here,
On 25/05/10 19:06, Robert Osfield wrote:
Hi John,
When reviewing the code I noticed that all the files you've written or
modified have a 3 space indentation in them. I can't get my head
around why on earth you'd want to use a odd number like 3 spaces. The
OSG uses 4 spaces as this is the most common and the most portable
spacing to use across OS's and dev tools.
I can't let the OSG drift off into some mess of coding styles so have
had to by hand go through all your files and fix them to adhere more
closely to the standard coding style that the OSG users. This has is
not a quick job, and one that does progress any features or bug fixes,
so it's darn frustrating to have to do it.
Could please in future adopt the coding style of the OSG when
submitting code as it's a real waste of my time having to fix it.
I agree it is best for the submitter to correct the submission, but
maybe GNU indent can help in some cases.
http://www.gnu.org/software/indent/
rgds
jp
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
--
This message is subject to the CSIR's copyright terms and conditions, e-mail
legal notice, and implemented Open Document Format (ODF) standard. The full
disclaimer details can be found at http://www.csir.co.za/disclaimer.html.
This message has been scanned for viruses and dangerous content by
MailScanner, and is believed to be clean. MailScanner thanks Transtec
Computers for their support.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
--
This message is subject to the CSIR's copyright terms and conditions, e-mail legal notice, and implemented Open Document Format (ODF) standard.
The full disclaimer details can be found at http://www.csir.co.za/disclaimer.html.
This message has been scanned for viruses and dangerous content by MailScanner,
and is believed to be clean. MailScanner thanks Transtec Computers for their support.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
