Hi Kristopher,

> To do this, it
introduces a protected (private) function that does the actual search
and replace. The implementation is based on the one found in
StandardShadowMap.

I didn't look at the implementation, but did you duplicate the functions from StandardShadowMap, or did you move them up the class hierarchy (into ShadowTechnique for example, even perhaps static if possible) so both StandardShadowMap and {Soft}ShadowMap can use them? I would prefer the latter of course...

Just wondering, good change in any case.

J-S
--
______________________________________________________
Jean-Sebastien Guay    [email protected]
                               http://www.cm-labs.com/
                        http://whitestar02.webhop.org/
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to