Hi Jorge, I'm just doing a review of the changes. Mostly the changes look OK, but I'm a bit concerned about the spread of IF (NOT ANDROID) IF (ANDROID) through the CMakeLIsts.txt files. Are all of these really necessary?
For instance the pkg-config entries, what happens if you leave these in? Perhaps if some areas of the CMake build are not appropriate they these could be switched off using a feature specific variable that is on by deafult for most platforms by off for Android. My wish would be to avoid an explosion of platform specific checks spreading througout the CMake build system. Further down the line I think it would be appropriate to have a something like a TARGET_PLATFORM CMake variable that we can set to ANDROID, or IOS, EMULATORS, DESKTOP_GL, DESKTOP_GLES1 etc. Perhaps this needs to broken down further such as for TARGET_PLATFORM, TARGET_GL_VARIANT. A discussion on osg-users is no doubt need to explore this further. I'm goig to go through you submissions another time and merge the changes I don't see as controversial and leave the items they need further discussion. More info later. Robert. On Fri, Mar 25, 2011 at 10:57 AM, Jorge Izquierdo Ciges <[email protected]> wrote: > Robert these are new patches that we've included in our Android toolchain. > They are minor fixes. > 1rst - Changes in Cmake: They make possible "make install" with the android > building. > 2nd - Script to use a 3rd party directory with basic libraries: > libjpeg,libpng,libtiff,giflib,freetype,curl,gdal. > 3rd - Change in the GLES library loading for Android. That should make GLES2 > work properly. > 4rth- Included two defines RGB8_OES and RGBA8_OES as a substitute in GLES > for RGB8 and RGBA8 > 5th - OpenGL and GLSL version identification changed to recognize GLES > versions properly > We've prepared a 3rdparty folder with binaries. Do you want us to upload the > package here in our server or in other server? > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
