Thanks Sukender, fix now merged and submitted to svn/trunk.
On Tue, May 17, 2011 at 1:34 PM, Sukender <[email protected]> wrote: > Hi Robert, > > There was a stupid parameter inversion in ExternalFileWriter.cpp. > Sorry for this. Here is the fix. > Cheers, > > Sukender > PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ > > ----- "Sukender" <[email protected]> a écrit : > >> Hi Robert, >> >> Happy to see the submission now suits OSG Core! Thank you for >> reviewing and integration. >> >> Well I recently updated OSG, and found FBX 2011.3.1 was not compiling >> anymore. I did not check anything an directly upgraded to 2012.1. I >> have no warnings under Win32 MSVC 9 (2008). >> >> Sukender >> PVLE - Lightweight cross-platform game engine - >> http://pvle.sourceforge.net/ >> >> ----- "Robert Osfield" <[email protected]> a écrit : >> >> > Hi Sukender, >> > >> > On Mon, May 9, 2011 at 2:46 PM, Sukender <[email protected]> wrote: >> > > As suggested, here is the modified helper to write >> > images/shaders/vegetables. >> > > Please note that I did not find better than a dynamic_cast to >> detect >> > if passed object is an image, shader, or whatever. If you don't find >> > better too, maybe the unique "write" method should be split into >> > writeImage, writeShader, etc.? >> > > >> > > Also find the modified FBX plugin. The DAE will be submitted soon. >> > > >> > > Please review and tell me what you think about it. >> > >> > What I think? Most excellent ;-) >> > >> > I have now merged and changes, as two submissions, one for the osgDB >> > changes and one for fbx plugin changes. >> > >> > BTW, I just built the fbx plugin under Linux and get lots and lots >> of >> > warnings. Do you see lots of warnigns under Windows? >> > >> > Robert. >> > _______________________________________________ >> > osg-submissions mailing list >> > [email protected] >> > >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
