Hi Robert, sorry, didn't mean to cause you any pressure at all. Naturally, please feel free to totally ignore until you've got the time. (just got worried the mail might not have gotten through)
Thanks for all your hard work, it's highly appreciated, tamer. On 11/07/2011 04:34 PM, Robert Osfield wrote: > Hi Tamer, > > The maill got through just fine and has been sitting in my in tray. > I've been swept off my feet with other work so haven't tended to > submissions much over the last month. Please be patient, I'll get to > it once things quieten down at my end. > > Robert. > > On 7 November 2011 15:06, Tamer Fahmy <[email protected]> wrote: >> Hi Robert, >> >> resending once more in case the mail didn't get through the last time. >> >> Greets, >> tamer. >> >> -------- Original Message -------- >> Subject: Re: Fix for mousewheel scroll down events stopping animations >> buglet in OrbitManipulator >> Date: Mon, 31 Oct 2011 02:36:39 +0100 >> From: Tamer Fahmy <[email protected]> >> To: OpenSceneGraph Submissions <[email protected]> >> >> Oops, forgot to mention: the buglet is only noticeable when ON_DEMAND >> rendering is requested. >> >> On 10/31/2011 02:30 AM, Tamer Fahmy wrote: >>> Hi all, >>> >>> attached is a fix for a little buglet in src/osgGA/OrbitManipulator.cpp >>> (against rev 12292). >>> >>> Currently issuing a mouse scroll DOWN event would stop updating >>> animations in progress. >>> >>> The fix consists of changing the line >>> us.requestContinuousUpdate( false ); >>> to: >>> us.requestContinuousUpdate( isAnimating() || _thrown ); >>> >>> in OrbitManipulator::handleMouseWheel() as has been done for the >>> GUIEventAdapter::SCROLL_UP case a couple of lines earlier or in >>> src/osgGA/FirstPersonManipulator.cpp. >>> >>> Thanks, >>> tamer. >>> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
