Hi WeSee,

I have just done a review and am happy to see an elegant final
solution that seems to tick all the boxes.  The only part I didn't
merge was the change to assign of colours.  The diff is below, the
simple colors->push_back(_primaryColor); version is your code.

$ diff GeometryRecords.cpp ~/OpenSceneGraph/src/osgPlugins/OpenFlight/
259c259,262
<                 colors->push_back(_primaryColor);
---
>                 // Incorporate Face transparency per osg-users thread "Open 
> Flight
>                 // characteristic not reflected in the current OSG" (Sept/Oct 
> 2011)
>                 colors->push_back(osg::Vec4(_primaryColor.r(), 
> _primaryColor.g(),
>                     _primaryColor.b(), ( 1.0 - getTransparency() ) ));

I didn't merge this as the original code was a specific workaround to
a problem.  Does this workaround cause problems for your datasets, if
so then we'd need to re-open the wider discussion of how to handle
this case.

Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to