Hi Aurelien, I have just done a review you changes and they strike me as rather verbose way of providing an interface with what is just a single line call in OpenGL. My current feeling is that providing a Vec4i or a GLenum[4] array as a parameter for storing the swizzle would be easier and less verbose to use, and far less intrusive to the API of osg::Texture. Keeping an API footprint of different features minimal yet complete makes a big difference to how readable class interfaces are and how easy they are to maintain so having a single feature spread out over many methods is far from this idea.
My preference is to simply have a setSwizzle()/getSwizzle() method in osg::Texture. We don't have a Vec4i or Vec4enum right now, but we probably needn't go this far, simply having access to a GLenum[4] would be sufficient. Thoughts? Robert. On 16 February 2013 13:16, Aurelien Albert <[email protected]> wrote: > Hi, > > Thanks for these explanations ! > > Adding the "UPDATE_TO_VERSION_SCOPED" macro correct the problem for osg > binary files. > > Here is the corrected patch. > > > Cheers, > Aurelien > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=52710#52710 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
