Hi Farsid, Thanks for the change. Once I get back to merging submissions I'll be able to tackle this.
Any chance you are working under Windows? I don't see these performance drops under Linux so sometimes don't spot problems like this. Windows implementation of the ostream to null is a real mess w.r.t performance. Do you see the performance issue only when INFO is on? Robert. On 9 April 2013 19:12, Farshid Lashkari <[email protected]> wrote: > Hi Robert, > > I just started looking into the shader composition feature. I enabled > shader composition on the osg::State object and noticed a 6x increase in > draw time. I figured that the default composer might have performance > issues, so I created a custom ShaderComposer that overrides > "getOrCreateProgram" and does nothing. This still resulted in a performance > drop. > > I looked into the "State::applyShaderComposition" method and noticed that > it will print debug information to the osg::INFO stream. I commented that > line out and the performance drop was gone. > > I'm not sure if the printing was accidentally left in or is meant to be > enabled. I've modified the function to only call the print function if INFO > logging is enabled. I've attached the change. > > Cheers, > Farshid > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
