Hi Sebastian,
On 9 September 2013 17:34, Sebastian Messerschmidt < [email protected]> wrote: > No offense, but this feels more like a hack than my solution. > Indeed, but it's hacks that external to the core OSG done for a very specific end user purpose, rather than hacks in the core OSG for a very specific end user purpose. The OSG has many users and many different usage models, internalizing all these usage models is in-inappropriate. Would you have me merge every little whim of the community or only should I be beholden to just your whims? Or should I try to make sure that any core modifications are fully justified? > The point is, that the original solution simply does not move any > information to the outside. I agree that is not the cleanest solution to > open up multiple code paths here. > What I don't get is the initial design. In my understanding it is bad > design not to call the original implementation (i.e. findFile), as a user > adding callbacks will fail. So chain of responsibility is broken here. > One could have the OpenFlight plugin defer to finding files to the image plugins, some plugins do this - for instance native OSG formats simply do a readImageFile() without forcing the find path. Changing OpenFlight across to not doing it's own findDataFile() would potentially break user code though if an image plugin doesn't both doing a findDataFile(). If one was to make something optional that it would be the findDataFile() call, it wouldn't be the ignoring the result of the file call. > > You are right however: Passing the information would solve my problem > since I only need to know which files are missing. > Also I want to point out that I'm not the only person having this problem. > Having more people wanting a hack to be merged into the core OSG doesn't change the fact that it's a hack. We can and should do better where we can. Robert.
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
