Hi Sebastian,
On 10 September 2013 06:23, Sebastian Messerschmidt < [email protected]> wrote: > Okay. So if I understood this correctly, it would be much cleaner if I > move the code inside the findDataFile and provide an option to enable > deferring the find to the image plugins. > I'll rethink the solution and re-submit it. Maybe we will need one or two > iterations to improve functionality while preserving code quality. > No I don't think moving code into findDataFile() is appropriate, the other plugins typically use findDataFile() to find their files so you certainly wouldn't want to go changing that. The only slightly unusual thing about the OpenFlight plugin is that it's taking over responsibility for doing the findDataFile() rather than defer this to the plugin handling readImageFile(). In your case I believe you are after disabling this call to findDataFile() P.S. I don't take any of this personally. I really appreciate your effort > of keeping the code clean and yet extensible. > Glad to hear you aren't taking this banter personally, email/forums can be such a crap medium for communicating - it's much easier to take things the wrong way without the tone of the voice and non verbal aspects of communication that smooth normal human interaction. >From my perspective all I want is for the code to improve. As things stand you are having to modify the code in awkward ways which tells me that the code needs to improve, but working out the best way is the hard part ;-) Robert.
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
