Hi Sebastian, Thanks for the change. I have reviewed your change and looked up the State::resetVertexAttributeAlias(bool) method. My inclination would be to relax the 5 texture limit for the compact case, and default it to 8, and provide an option for passing in a user defined number of texture units to set up. I think the compact case would still be the appropriate default. The non compact case is just reusing the slots that fixed function pipeline had.
Thoughts? Robert. On 22 November 2014 10:16, Sebastian Messerschmidt < [email protected]> wrote: > Am 21.11.2014 16:33, schrieb Robert Osfield: > > Hi Sebastian, > > There several changes to svn/trunk that aren't reflected in your own > State.cpp, could you have a look at svn/trunk's State.cpp and see what > parts of your submission. > > Please refer to the new attachment. > > > As for the issue in general, it's hard to know the best way forward > without spending time reflecting on the issue. An example that illustrates > the problem would be useful in this process. > > I could provide some example using vertexAttribute aliasing set to true > which uses more than 5 texture coordinates. In this case there no automatic > aliasing will happen due to the "compactAliasing" parameter always set to > true in > void State::resetVertexAttributeAlias(.. > See State.cpp at line 835 for the only use of the flag. > > > If you still need some example, it would only demonstrate failure for more > than 5 texture coordinates. > > Cheers > Sebastian > > > Robert. > > > On 13 November 2014 09:37, Sebastian Messerschmidt < > [email protected]> wrote: > >> Hi Robert, >> >> I've asked this some time ago in the user-forum but never got an answer: >> <snip> >> Hi, >> >> When vertex attribute aliasing is enabled, it seems that the constructor >> calls the resetVertexAttributeAlias with true (i.e. compact aliases) in any >> case. >> I need more than 5 texture coordinates however. Is there any reason for >> the compact aliases? >> I was able to get my complex models by setting the compactAliasing >> parameter to false in the State constructor. >> </snip> >> >> The change will use complete aliases so one can use more than 5 texture >> coordinates with attribute aliasing. >> Unfortunately I didn't see a way to make this configurable >> I decided to simply submit the change, to bring it to your and others >> attention. >> >> Changes are made against revision 14157 >> >> >> Cheers >> Sebastian >> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > > > _______________________________________________ > osg-submissions mailing > [email protected]http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
