On 20 February 2016 at 01:17, Jannik Heller <[email protected]> wrote:

> Hi Robert,
>
> Just wondering if this submission was forgotten? If you don't like the
> suggested fix, then just let me know and we can try to come up with a
> different solution.
>

I just had a look at the changes on github but can't see an easy way to
grab the full modified files to do a proper view.

As a general note, the graphical diff that github falls far short of what I
feel is necessary to full view the wider code and the impact of the
changes, for anything but trivial changes pulling changes like this is
really dangerous - makes me wonder just how many projects make mistakes
because merging is made so easy one bypasses due process in reviews.

Could you send me the modified files.

Cheers,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to