On 22 February 2016 at 10:29, Jordi Torres <[email protected]> wrote:

> Probably you already have seen that ( if that is the case sorry for the
> noise), but just in case... There is a split button to see the changes
> side-by-side in github. Did you tried it?
>

Split like all the views I've come across that gthub provides only give you
a small window around the changed lines, this is insufficient for a proper
code review.  To understand a change properly you need to understand what
the original code does, and how the modified code affects this.  Doing
reviews on github is effectively working with the blinkers on.

Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to