Hi again, Forgot to add the link to the GitHub help page: https://help.github.com/articles/checking-out-pull-requests-locally/
/Björn From: osg-submissions [mailto:[email protected]] On Behalf Of Björn Blissing Sent: Monday, February 22, 2016 12:29 PM To: OpenSceneGraph Submissions <[email protected]> Subject: Re: [osg-submissions] osgParticle freeze on cull fix Hi Robert et al. My work flow regarding pull request is to first merge the changes to a branch on my local machine. Then I can use my normal diff tools and even compile the code if necessary. Then (if I am satisfied) I can merge it back to master and push the changes to the main repo. Regards Björn From: osg-submissions [mailto:[email protected]] On Behalf Of Robert Osfield Sent: Monday, February 22, 2016 11:38 AM To: OpenSceneGraph Submissions <[email protected]<mailto:[email protected]>> Subject: Re: [osg-submissions] osgParticle freeze on cull fix On 22 February 2016 at 10:29, Jordi Torres <[email protected]<mailto:[email protected]>> wrote: Probably you already have seen that ( if that is the case sorry for the noise), but just in case... There is a split button to see the changes side-by-side in github. Did you tried it? Split like all the views I've come across that gthub provides only give you a small window around the changed lines, this is insufficient for a proper code review. To understand a change properly you need to understand what the original code does, and how the modified code affects this. Doing reviews on github is effectively working with the blinkers on. Robert.
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
