Hi Ben, I am working through the osg-submissions backlog in date order so haven't yet had the opportunity to review the changes.
I don't know if this is an issue with your submission but it has been an issue previously is that when we update to more modern ffmpeg API we end up breaking the build against older versions of ffmpeg that OSG users still rely upon - for instance distribution like RedHat have a long life cycle where users on it work quite happily till we make an OSG release that has 3rd party version dependencies that break the build. This backwards compatibility issue is why there are lots of #if #else blocks in the ffmpeg plugin. Is backwards compatibility something you considered when making your changes? Robert. On 30 May 2016 at 23:35, Ben Woods <[email protected]> wrote: > On 21 May 2016 at 16:10, Ben Woods <[email protected]> wrote: >> >> Please find attached files to update the files in src/osgPlugins/ffmpeg/ >> to replace the deprecated FFmpeg API with the new FFmpeg API. >> >> Without these changes OpenSceneGraph will fail to build against FFmpeg >> 3.0.x. >> >> These are full files, with changes made against those in the current >> GitHub repository. All 4 files should be place in src/osgPlugins/ffmpeg/. >> modified: FFmpegDecoderAudio.cpp >> modified: FFmpegDecoderVideo.cpp >> modified: FFmpegDecoderVideo.hpp >> modified: FFmpegParameters.cpp >> >> Regards, >> Ben >> >> -- >> From: Benjamin Woods >> [email protected] > > > Hi everyone, > > Just wondering if anyone has had a chance to look at this patch set yet? It > is required in all distributions that package OpenSceneGraph and are > updating to FFmpeg 3.0.x. > > Regards, > Ben > > -- > From: Benjamin Woods > [email protected] > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
