Thanks Bjorn, change now merged. I will be tagging a 3.5.4 release soon so you'll be able to use that in version checking. Cheers, Robert.
On 30 June 2016 at 21:12, Björn Blissing <[email protected]> wrote: > Hi Robert, > > > I have updated the pull request with the new naming. > > > Regards > > Björn > > ________________________________ > Från: osg-submissions <[email protected]> för > Robert Osfield <[email protected]> > Skickat: den 30 juni 2016 18:08:10 > Till: OpenSceneGraph Submissions > Ämne: Re: [osg-submissions] DestructionOperation on Viewer > > Hi Bjorn, > > I have reflected on the names, set/upCleanUpOperation() is the one > that feels most natural to me, could you rename DestructionOperation > to CleanUpOperation and _destroyOperation to _cleanUpOperation and > then generate a pull request for this. I'll then merge this as we'll > then have a cleaner history for this feature. > > Thanks, > Robert. > > On 30 June 2016 at 16:35, Björn Blissing <[email protected]> wrote: >> Hi Robert, >> >> I considered several antonyms to realize, such as cleanup, retire and >> decommission. As well as variants like preClose or beforeClose. >> >> But I have little invested in the current naming. So feel free to use >> whatever you feel appropriate. >> >> Regards >> Björn >> >> Den 30 juni 2016 5:16 em skrev Robert Osfield <[email protected]>: >> >> Hi Bjorn, >> >> Interesting approach. Will need to think about it some more before >> deciding on what to do, but provisionally it makes sense and looks >> clean. >> >> The only thing that jumped out on first review is the naming. It's >> not an actual Destruction operation, rather a clean up operation. >> However, the RealizeOperation can also be thought as something that >> doesn't actually doing an realizing of the graphics context, just set >> up or testing of graphics capabilities. Whatever, the final name I'd >> keep the name of the method the same as the name of the member >> variable that it maps too, so would name it _destructionOperation. >> >> Currently I'd have slight preference for set/getCleanUpOperaration(). >> Happy to take input from others on the naming front. >> >> Robert. >> >> Robert. >> >> On 30 June 2016 at 16:14, Björn Blissing <[email protected]> wrote: >>> Hi, >>> >>> During my development with the Oculus Rift I found my self in need for a >>> operation that runs before the graphics context is close when the >>> application ends, i.e. I still need to have a valid context. >>> >>> The problem is described in detail here: >>> http://forum.openscenegraph.org/viewtopic.php?t=15186 >>> >>> I have implemented this as something similar to the realize operation, >>> but >>> as a operation that runs before the context is closed. >>> >>> It as been submitted as: >>> https://github.com/openscenegraph/OpenSceneGraph/pull/91 >>> >>> Regards >>> Björn >>> >>> ------------------ >>> Read this topic online here: >>> http://forum.openscenegraph.org/viewtopic.php?p=67935#67935 >>> >>> >>> >>> >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
