Hi Torben, I'm happy to merge changes to solve platform specific build problems but obviously not ones that fix one build combination but break others.
In the case of the libs that are required for your build combination they would need to be made optional. I would suggest having a single variable that the CMakeLists.txt includes then have FindNVTT.cmake work out what should go into this depending upon what is available/required. Robert. On 12 May 2017 at 11:40, Torben Dannhauer <[email protected]> wrote: > Hi Robert, > > with the default nvtt package downloadable from the internet, it is not > possible to compile nvtt plugin in OSG with windows. It fails during > linking, sine it misses some symbols from the below libraries. > > We have two options to fix it: > a) change the nvtt buildscripts so it links all required library already > when building the nvtt libraries. -> OSG can use them without changing > anything in OSG. > b) adapt OSG (nvtt plugin) to link also against the require additional > libraries. > > I think we should go for b) as I always try to change external projects only > on a good reason (e.g. true bugfixes). > Of course my changes always reflect only the windows parts since I do not > develop on linux. > > I dont have all details on my stack after some month, but I can retry it and > give you specific feedback when we try to come to a decision within next > days to close this issue. > > What do you think? > > Torben > > > -----Ursprüngliche Nachricht----- > Von: osg-submissions > [mailto:[email protected]] Im Auftrag von > Robert Osfield > Gesendet: Freitag, 12. Mai 2017 12:29 > An: OpenSceneGraph Submissions <[email protected]> > Betreff: Re: [osg-submissions] missed submission? 3rdParty Package - NVTT > updates > > Hi Torben, > > I applied your modified CMakeLists.txt, but didn't need to with the > FindNVTT.cmake as it was identical to the one OSG master already. > Then I did a build and get the error: > > CMake Error: The following variables are used in this project, but they are > set to NOTFOUND. > Please set them or make sure they are set and tested correctly in the CMake > files: > NVBC6H_LIBRARY > linked by target "osgdb_nvtt" in directory > /home/robert/OpenSceneGraph/src/osgPlugins/nvtt > NVBC7_LIBRARY > linked by target "osgdb_nvtt" in directory > /home/robert/OpenSceneGraph/src/osgPlugins/nvtt > NVSQUISH_LIBRARY > linked by target "osgdb_nvtt" in directory > /home/robert/OpenSceneGraph/src/osgPlugins/nvtt > NVTHREAD_LIBRARY > linked by target "osgdb_nvtt" in directory > /home/robert/OpenSceneGraph/src/osgPlugins/nvtt > > Reverting the src/osgPlugins/nvtt/CMakeLists.txt fixes the build. > > My dev system is Kubuntu 16.04. The NVTT_LIBRARY is found just fine, the > plugin builds OK, but NVSQUISH* and NVTHREAD* are all *-NOTFOUND. > > The /usr/include/nvtt.h file has #define NVTT_VERSION 200 in it. > > Your changes clearly aren't safe to merge as is. What specific problem were > you trying to fix? > > Robert. > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph. > org > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
