Hi Ben,
Question of the day: I find a setTextureSize method on ShadowMap and SoftShadowMap, but not on the 3 other techniques (even in SVN head).
In addition to what Robert said, I'll add that setTextureSize is only
relevant to texture-based shadow techniques, so for example it makes no
sense for ShadowVolume to have one. So you couldn't just move
setTextureSize to the parent class osgShadow::ShadowTechnique.
There could be a split into two subclasses of ShadowTechnique above the
actual concrete techniques, something like:
ShadowTechnique
TextureShadowTechnique (find a better name...)
ShadowTexture
ShadowMap
SoftShadowMap
ParallelSplitShadowMap
LightSpacePerspectiveShadowMap (one can only wish... :-) )
GeometryShadowTechnique
ShadowVolume
(any others?)
That would avoid duplicating setTextureSize, and maybe some others?
Perhaps for such a simple method it's not that useful though. We could
also have a virtual setTextureSize in ShadowTechnique and make it throw
an exception (or print a message) if it's called for ShadowVolume, since
it's currently the only non-texture-based technique.
J-S
--
______________________________________________________
Jean-Sebastien Guay [EMAIL PROTECTED]
http://www.cm-labs.com/
http://whitestar02.webhop.org/
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
