Hi Erik, Over the last four weeks there has been lots of discussion about warnings including the VS pragrma disables in osg/Export. There is already support in the CMake build system to switching off these VS disables - see the OSG_DISABLE_MSVC_WARNINGS variable when you run CMakeSetup, so you could try this.
If you track down the discussions on osg-users you'll see that I favour moving the pragma's out of the headers completely and work to get the headers compiling cleanly where possible. VS does produce some rather misleading and unhelpful warnings though that are generated in the implementation where the code is perfectly correctly, so disabling these specific warnings is still appropriate and best done by using compiler options rather than pragma. Again there is some support for this in the CMake build system. The last discussion on warnings ended with me awaiting on feedback of how things stand with warnings under VS with/without the OSG_DISABLE_MSVC_WARNINGS. I can only guess that as everyone is busy they have other things to chase up which are a higher priorty. Feel free to dive in and do this testing and send in the warning output that you get when you switch off the warning disable so that we can review what changes would be best to implement. Cheers, Robert. On Wed, Jan 21, 2009 at 11:23 PM, Erik Johnson <[email protected]> wrote: > Hi, > > Through some debugging, I discovered that the osg/Export header file is > disabling the C4996 "method is deprecated" compiler warning message*. > That's all well and good when compiling OSG, but it is affecting *any* > project that happens to include that file (directly or indirectly). In my > case, I have a class method marked as deprecated but since the class derives > from an OSG class, the osg/Export header gets pulled in a squelches my > compiler warning. > > Would it be agreeable to remove the disabling of the MSVC 4996 warning in > the osg/Export file? It doesn't appear that OSG itself is generating any > deprecated compile warnings. > > *The MSVC C4996 compile warning is generated when a method declaration is > prefixed with " __declspec(deprecated)" and is useful to notify the user > that a deprecated method is being used. > > Thanks, > Erik Johnson > > > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
