Hi Bryan,

On Wed, May 20, 2009 at 3:57 PM, Thrall, Bryan
<[email protected]> wrote:
> Should NodeVisitor::DatabaseRequestHandler::requestNodeFile still have
> the options argument default to 0 (requestNodeFile(..., const
> osg::Referenced* options=0))?

Yes this is correct and as intended.  This allows the current user
code that accesses the DatabaseRequestHandler to compile with the
latest rev of the OSG without any chances, and without any behavioral
differences.

> I'm not sure if that'll cause any problems, but it doesn't match
> osgDB::DatabasePager. Fixed version of NodeVisitor attached to make it
> match.

The DatabasePager is effectively an internal implementation detail
that users shouldn't be calling the requestNodeFile method on, rather
they should be accessing it through the DatabaseRequestHandler. The
DatabasePager does need a default value for the options pointer,
requiring it to be explicitly defined is appropriate.

Robert.
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to