Hi Robert,
So this week I rather than just hack a bit of extensibility into Dragger to allow me to observer changes to the Dragger, I took the opportunity to refactor osgManipulator to make it simpler to use, more encapsulated, easier to use with conventional nodes and more extensible. These changes are now checked into OSG svn/trunk, these do change the API a bit so does break the strict API compatibility with previous rev's of osgManipulator, but to enable better backwards compatibility I've kept around two now redundant classes (CommandManager and Selection.)
That's good, the changes you've made do clean up the osgManipulator API a good deal. We use it pretty extensively in one of our apps, so I'd like to test your changes against this app in the next few days to see if anything's broken. Actually I expect that I'll be able to clean things up a bit since we would have needed the DraggerCallback to push the changes to other objects in the past. We did that in another way (our event handler takes the Selection's transform after it's handled the events and sends it to the object concerned) but it will be clearer with the new callback.
So I'll try to test with OSG SVN soon and give you some feedback. I've got a pretty tight schedule right now but this is a change that could potentially affect us in a bad way so I'd like to know sooner rather than later. :-)
I'd also like feedback on whether we should remove the headers and class definitions for Selection and CommandManager
I agree with John, remove them. The changes will be in 2.10 so it's pretty clear that there will be a break in API for some things. One thing I'd suggest though, is to make a small page on the wiki (I don't know if we have a "Porting guides" section or wherever the page about porting from osgProducer to osgViewer is...) giving a quick overview of how to port to this new API (roughly what was in the message you sent). Others can then also add some details about some specific experiences porting from the old osgManipulator to the new osgManipulator to that same page.
I look forward to seeing all this in action :-) Good work, J-S -- ______________________________________________________ Jean-Sebastien Guay [email protected] http://www.cm-labs.com/ http://whitestar02.webhop.org/ _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
