Thanks for the fixes. Changes are now committed to svn trunk. About the second issue, it seems a much complicated piece of code for what it's doing. I suggest this lighter and cleaner alternative instead of a template with three different typename parameters and the huge expression with four static_cast.
#define inTolerance(base, match, tolerance) ( osg::absolute((base)-(match)) < tolerance ) However, this part of the code was written by Peter Particle, so I'll redirect to him both proposals. Meanwhile, can you test if it is working for you right now? Regards, On Tue, May 24, 2011 at 11:08 PM, Ryan Pavlik <[email protected]> wrote: > The changes to osgpreview.cpp are for the first issue, while the changes to > utility.h are for the second way of solving the second issue. > Ryan > > On Tue, May 24, 2011 at 12:59 PM, Javier Taibo <[email protected]> > wrote: >> >> Hi Ryan, >> >> Thank you for the patches. Can you send the whole files instead of >> patches, please? You can zip all files together to make it easy. >> >> Thank you! >> >> >> Best Regards, >> >> >> On Tue, May 24, 2011 at 7:28 PM, Ryan Pavlik <[email protected]> wrote: >> > Hello all, >> > I've attached small patches to two issues I've found with Maya2OSG. >> > One allows it to build successfully with the current 2.8 branch - there >> > are >> > some manipulators not available in this branch so we just disable them >> > by >> > checking the osg version. >> > The other issue was ambiguity in calling inTolerance, preventing me from >> > building successfully on VC9 x64. I solved this two different ways: >> > take >> > your pick of which way you prefer. >> > >> > I've made inTolerance a template function with a single parameter type >> > and >> > explicitly specified the template parameter in the one case. >> > (fix-vc9-build) >> > inTolerance is a template function with three parameter types, and >> > static_casts all arguments to the type of the tolerance parameter before >> > doing math. This one doesn't require explicit template param >> > specification, >> > and seems "more correct" to me, or at least more explicit in how it >> > works. I >> > personally prefer this one. (alternate-fix-build) >> > >> > These patches were made against the latest svn trunk of maya2osg using >> > tortoisesvn. >> > Ryan >> > -- >> > Ryan Pavlik >> > HCI Graduate Student >> > Virtual Reality Applications Center >> > Iowa State University >> > >> > [email protected] >> > http://academic.cleardefinition.com >> > >> > _______________________________________________ >> > osg-users mailing list >> > [email protected] >> > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> > >> > >> >> >> >> -- >> Javier Taibo >> _______________________________________________ >> osg-users mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > -- > Ryan Pavlik > HCI Graduate Student > Virtual Reality Applications Center > Iowa State University > > [email protected] > http://academic.cleardefinition.com > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > -- Javier Taibo _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
