Hi Ulrich, On 4 February 2013 23:48, Ulrich Hertlein <[email protected]> wrote: > I have never changed the CMake variable (having only vaguely been aware of > it), but have > always used 'source.get()' in my own code. > > Following the mantra 'explicit is better than implicit' I would like to > advocate to remove > the 'feature' (basically setting it to OFF) AND to remove the CMake variable. > > This follows std::shared_ptr and std::unique_ptr. > > Yes, this will break some code but maybe for the better?
I feel the issue boils down to "Convenience and readability of short hand vs inconvenience of an implicit cast causing a bug." I'm torn on the issue but am more inclined toward default to OFF and not using the implicit cast. > Cheers, > /ulrich > > PS: On a related note: how do you folks feel about slowly starting to adopt > C++11 > features? I feel like a kid in a candy store with all the new stuff that has > come along! :-D If I was to write a clean room scene graph I'd seriously consider setting a higher standard of the C++ compiler required, but given we have an existing codebase, a big community across a wide range of platforms that they require supported I don't think adopting recent C++ features is appropriate right now. I don't care about specific features or versions, only that whatever merge works against the platforms that our users are working against. Robert. _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
