Sorry; I cross-posted this to osg-users but forgot to mention why.
I wanted to start a discussion on the CMake variable
OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION. Does anyone else besides me change
this variable from its default ON state to OFF? If not, should we just remove it?
The reason I ask is that it seems like every time I do an update from trunk, the
latest source contains some changes that assume this variable is always on, and
the code fails to compile if the variable is off. Here's an example:
osg::ref_ptr< osg::Group > source;
osg::Group* dest;
dest = source; // Compile error, should be "dest = source.get()"
I got in the habit of always disabling implicit ref_ptr output conversion
because someone once tried to use my osgWorks project with an OSG that had been
built with the CMake variable turned off. The only way for me to make sure my
project builds is to do all my testing with the CMake variable turned off. Code
written with the variable in an OFF state will build whether the variable is ON
or OFF, but code written with the variable in its default ON state stands a good
chance of failing to compile when the variable is flipped OFF.
If no one else is turning it OFF and are submitting changes that assume it's ON,
then perhaps I'm better off if I (osgWorks, osgBullet, osgAudio, etc) simply
stop supporting the variable in an OFF state...? If so, it begs the larger
question: should we simply remove the variable altogether?
-Paul
On 2/4/2013 2:18 PM, Paul Martz wrote:
This is just a start, there are many others. Just don't have time to fix them
all at the moment.
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
