Hi Tom, et. al,
On 3 July 2014 13:41, Jolley, Thomas P <[email protected]> wrote: > Could you send me the warnings. I may not be able to do anything about > them in the OSG-3.2 branch if resolving them affects the ABI but can > certainly look at addressing them in svn/trunk. > > > > /usr/OpenSceneGraph-3.2.1-rc5/include/osg/ValueObject:45: warning: 'class > osg::ValueObject::GetValueVisitor' has virtual functions but non-virtual > destructor > > /usr/OpenSceneGraph-3.2.1-rc5/include/osg/ValueObject:70: warning: 'class > osg::ValueObject::SetValueVisitor' has virtual functions but non-virtual > destructor > > > > > > /usr/OpenSceneGraph-3.2.1-rc5/src/osgPresentation/PropertyManager.cpp:95: > warning: 'class MySetValueVisitor' has virtual functions but non-virtual > destructor > > > > /usr/OpenSceneGraph-3.2.1-rc5/src/osgPlugins/osc/OscSendingDevice.cpp:234: > warning: 'class OscSendingDeviceGetValueVisitor' has virtual functions but > non-virtual destructor > Thanks. All are easy warnings to fix, but would adding a virtual destructor change the ABI? If it changes the ABI then I don't feel it's appropriate to merge the change into the OSG-3.2 as my intention is for 3.2.1 to remain binary compatible with 3.2.0. Thoughts on this everyone? Robert.
_______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
