Thanks Riccardo. I'm just heading offline for the evening so will have a look tomorrow.
On 14 June 2017 at 17:23, Riccardo Corsi <[email protected]> wrote: > Hi Robert, > > I've created a pull request. > You can modify the SO version number on the PR branch to make it consistent > before merging back to the main repo, > I've allowed contributions from maintainers. > Thanks, > Riccardo > > > On Mon, Jun 12, 2017 at 5:49 PM, Robert Osfield <[email protected]> > wrote: >> >> Hi Riccardo, >> >> On 12 June 2017 at 12:35, Riccardo Corsi <[email protected]> >> wrote: >> > from within the BinaryStreamOperator we can get the file version with >> > getInputStream()->getFileVersion() >> > and decide to read/write the block size on 4 or 8 bytes accordingly. >> > >> > For the file version check would you use > 148 (i.e. osg 3.5.6) ? >> >> I would bump the SO version number specifically for this addtion, so >> bump it to 149 at the same time as merging the change this way we >> avoid any chance that there might be problem .osgb's created. >> >> Robert >> _______________________________________________ >> osg-users mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
