Hi Dan, I was soooo hoping that all would be OK and I could take the whole evening off... However, It's far better to catch stuff before a release than after though, so I appreciate your efforts on testing.
I have reproduce the ever expanding bounding box thanks to the you test program, and a bit of debugging revealed that it's the increase in _textBB size due to apply margin and the shadow offsets on each setPosition() call. The only proper fix I could come up with was to introduce a _textBBWithMargin so that the margin+shadows don't affect the main _textBB. This change required far more lines of code to be changed than I'd like to do this close to a release, but I feel it's worth the risk to solve the problem. Fingers crossed I don't introduce any regressions with this change. I have checked in the changes to OSG master the and the OpenSceneGraph-3.6 branch. https://github.com/openscenegraph/OpenSceneGraph/commit/6bfca1582efae9606e18883971c95eb734d70058 If this works OK then I'll tag a rc7. Cheers, Robert. On 6 April 2018 at 17:08, Daniel Emminizer, Code 5773 <[email protected]> wrote: > Hi Robert, > > I've been testing the RC5 and I have a problem with text. I saw PR # 523 and > thought it might be the same problem. It looks quite similar to the issue > I'm seeing. I updated to RC6 (includes PR 523) and things look a lot better, > but not completely fixed. > > I have finally been able to reproduce this in native OSG without any extra > libraries. Attached is a .cpp modification of the osgtext example that > demonstrates the problem. This is tested on RC6. > > > The text "Left" is on the left side, and (correctly) shifts position each > frame (up and down). This is important, because the position changes every > frame. But the bounding box on the Left text (incorrectly) keeps getting > bigger and bigger. > > The text "Right" is on the right side, and its position is set to the right > side of "Left" text, based on Left's bounding box. You'll see it float to > the right as the frames redraw. I would expect "Right" to stay in the same > place horizontally, but it does not. > > > The problem seems to be related to: > 1) Changing the position of the text to a new position > 2) Having a drop shadow > > > Unfortunately I do not know how to fix this. I can work on it if you > want/need, but perhaps you see the problem right away? Please let me know if > the attachment osgtext.cpp doesn't come through for some reason. > > - Dan > > > -----Original Message----- > From: osg-users [mailto:[email protected]] On Behalf > Of Robert Osfield > Sent: Friday, April 06, 2018 10:02 AM > To: OpenSceneGraph Users > Subject: [osg-users] OpenSceneGraph-3.6.0 release candidate 6 > > Hi All, > > I have just tagged release candidate 6: > > > https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGraph-3.6.0-rc6 > > I'm really hoping this is now and we are good to go. If things are > building and running OK I'll tag 3.6.0 tomorrow. So yet another big > PLEASE test :-) > > Let us know about success or failures so we know where we are at for the > release. > > Thankyou! > Robert. > > --Changes since rc5 > > Fri, 6 Apr 2018 14:47:54 +0100 > Author : Robert Osfield > Updated for rc6 > > Fri, 6 Apr 2018 14:17:35 +0100 > Author : Robert Osfield > Fixed warning > > Fri, 6 Apr 2018 14:07:58 +0100 > Author : Robert Osfield > Changed TextBase::setAlignment() to use computeGlyphRepresentation(); rather > than computePositions(); to address issues seen with calling > Text::setAlignment() after calls to Text::setText() > > Fri, 6 Apr 2018 14:06:50 +0100 > Author : Robert Osfield > Added osgtext --alignment test to look the effect of calling > Text::setAlignent() before and after the Text::setText(). > > Thu, 5 Apr 2018 18:00:30 +0100 > Author : OpenSceneGraph git repository > Merge pull request #525 from emminizer/fix-windows-exportosgDB: Added missing > extern OSGDB_EXPORT. > > Thu, 5 Apr 2018 10:51:24 -0400 > Author : Daniel Emminizer > osgDB: Added missing extern OSGDB_EXPORT. > > Thu, 5 Apr 2018 14:14:49 +0100 > Author : Robert Osfield > Quietened down debug message output for osgText shader setup and > Drawable::createVertexArrayStateImplementation > > Thu, 5 Apr 2018 12:35:36 +0100 > Author : Robert Osfield > Changed DisplaySettings::setShaderHint(..) messages to INFO > > Thu, 5 Apr 2018 12:19:56 +0100 > Author : Robert Osfield > Updated ChangeLOG and news > > Thu, 5 Apr 2018 11:21:55 +0200 > Author : Philippe Renon > mingw: fix compile error in GraphicsWindowWin32.cppcompilation error was > introduced by msvc specific change see > https://github.com/openscenegraph/OpenSceneGraph/commit/bb169979a1054e2fa63a7ea82c9c8bec87e90494 > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
