RE: [osg-users] OpenSceneGraph-1.2 Release prep

[Philip Taylor]

In a similar vein to my recent posting, the following line in the OpenThreads 8th Sep tarball still contains the following VS6  compilation error in Win32Thread.cpp(554) line should read

 

     DWORD res =

and NOT

 

    DWORD_PTR res =

 

unless there is a 64-bit compilation issue. The function in line 555,  SetThreadAffinityMask, returns a DWORD value under VS 6, and I find hard to believe that Microsotf would change the return type since it could break applications.

 

Given that the last reply failed to store the message properly, I have not attached the changed file.

 

Regards

 

Philip

 

-----Original Message-----
From: Philip Taylor [mailto:[EMAIL PROTECTED]
Sent: 09 September 2006 12:59
To: osg users
Subject: RE: [osg-users] OpenSceneGraph-1.2 Release prep

Robert, Don (Burns)

The thread entry for this message displays the two files I attached to the original listing but not the message, which was as follows:

 

 

 

The Producer tarball for 8 Sept still contains problems that prevent error free compilation on VS6.

 

============================

PipeTimer.cpp(142) - Line should read:

 

    return double(GLint64EXT(timeElapsed)) * _div;

 

============================

RenderWindow_Win32.cpp(various)

 

The calls to SetWindowLongPtr within _WIN32 conditional assembly should read

 

            SetWindowLong(_win, GWL_WNDPROC, (LONG) _oldWndProc);

as VS6 does not have either SetWindowLongPtr or GWLP_WNDPROC or LONG_PTR

 

============================

Additionally, Mike Wittman made the suggestion that the _WIN32 references that I suggested should be modified to read

 

#if defined(WIN32) && _MSC_VER == 1200 // 1200 == VC++ 6.0

 

although I now see that Producer already has a mechanism defined in the  <export> file involving the use of _WIN32_IMPLEMENTATION, so perhaps there is a better implementation style either using _WIN32_IMPLEMENTATION or a new #define along the lines of _VS6_IMPLEMENTATION.

 

============================

 

The two modified files (from the tarball) are attached for the first two items, since they fix the compilation errors, but the issue with _WIN32 I leave to others since this is more a design issue.

 

Regards

 

Philip

 

 

_______________________________________________
osg-users mailing list
osg-users@openscenegraph.net
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/