I have have review your changes, and it looks to me that the PipeTimer.cpp change to have a GLint64EXT will break cross platform builds staight away as this type will very Windows specific. A #idef VS6 of some type will be required instead. Curiously include/osg/Timer uses 64 bit ints and is able to cope with a cast to double with using GLint64EXT. The Timer code has been in place for years without problems under VS6.0.
The changes to RenderSurface_Win32.cpp from you also look that have half been merged already :
http://www.openscenegraph.org/viewcvs/Producer/src/RenderSurface_Win32.cpp?r1=1.96&r2=1.97&root=Producer
However, you latest attachement is a little different, your original submission used GWLP_WNDPROC and the new one use GWL_WNDPROC, and changes another Ptr appended function name to the one with Ptr appended. The new one you have looks more consitent.
Could VS7.x and VS8.x developers try out Philip's RenderSurface_Win32.cpp? If it looks ok for 32 and 64 build I think it would good to get this integrated before 1.2-rc3.
I'll hold back rc3 till I get some feedback on this issue.
Robert.
On 9/9/06, Philip Taylor <[EMAIL PROTECTED]> wrote:
Robert, Don (Burns)The Producer tarball for 8 Sept still contains problems that prevent error free compilation on VS6.============================PipeTimer.cpp(142) - Line should read:return double(GLint64EXT(timeElapsed)) * _div;============================RenderWindow_Win32.cpp(various)The calls to SetWindowLongPtr within _WIN32 conditional assembly should readSetWindowLong(_win, GWL_WNDPROC, (LONG) _oldWndProc);as VS6 does not have either SetWindowLongPtr or GWLP_WNDPROC or LONG_PTR============================Additionally, Mike Wittman made the suggestion that the _WIN32 references that I suggested should be modified to read#if defined(WIN32) && _MSC_VER == 1200 // 1200 == VC++ 6.0although I now see that Producer already has a mechanism defined in the <export> file involving the use of _WIN32_IMPLEMENTATION, so perhaps there is a better implementation style either using _WIN32_IMPLEMENTATION or a new #define along the lines of _VS6_IMPLEMENTATION.============================The two modified files (from the tarball) are attached for the first two items, since they fix the compilation errors, but the issue with _WIN32 I leave to others since this is more a design issue.RegardsPhilip-----Original Message-----Hi All,
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Robert Osfield
Sent: 08 September 2006 14:36
To: osg users
Subject: [osg-users] OpenSceneGraph-1.2 Release prep
Since 1.2-rc2 seems to have to reasonably smoothly, at least on the main platforms, I feel pretty comfortable with going for the final 1.2 release this Monday (11th September). I have merged updates to the Xcode projects from Eric, and a few other minor tweaks/additions such as the perl script for VS6.0 users from Mike Wittman, and these will need testing so later today I'll tag and release 1.2-rc3.
I have been putting together a news item - the source is found in OpenSceneGraph/NEWS.txt and also been used (copy and pasted) on the OSG websites news page:
http://openscenegraph.org/osgwiki/pmwiki.php/News/News
Could users review this and point out any mistakes or omissions.
I'm just waiting on the OpenSceneGraph/ChangeLog to be updated (I'm still suffering from having to use a modem so this will take a looong time). Once the ChangeLog is updated I'll be able to produce a fine AUTHORS.txt file to go with the release, I'll post this for your review once its complete. Last time I did it we were up to 208 contributors, which is 11 new contributors since 1.1, which is to me is quite suprising for a periord of less two months, suprising in good way ;-)
Thanks,
Robert.
_______________________________________________
osg-users mailing list
[email protected]
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/
_______________________________________________ osg-users mailing list [email protected] http://openscenegraph.net/mailman/listinfo/osg-users http://www.openscenegraph.org/
