Robert,
On Tuesday 07 November 2006 10:27, Robert Osfield wrote:
> > Ok. If you have an other fix for that. I would like to test that on our
> > rgb files.
>
> I have pondered on adding the a check later, but there is two seperate
> loops later in the code, which would make it better to do the
> check/modify above this - and right where you added your workaround.
>
> I now think the only problem with your workaround is the assumption of
> 1 byte per colour channel.
Ah, I see ...
I did not think of that ...
> > When I tested the loaders with the Flightgear models I run a script doing
> > a osgconv to ive on any 3d model I could find in the data directiory.
> > Just to see that that it does not crash. If I remember well, this osgconv
> > crashed on about 20% of the 3d models due to crashes in the rgb loader.
> > So there are plenty of them out there.
> > Past that change in my private tree the models are converted without
> > crash. Not sure if they are also correct ...
>
> I'm not against adding an extra check, similiar to your workaround,
> but looking at the data in the file it looks very much like that the
> files themselves are suspect.
As told earlier, I don't know what is *right*. But others can read them.
I also doubt that there is an official iso standard for RGB files, true?
So, I can change the files in flightgear's cvs and convert them all.
But OTOH I believe that it is an additional value for osg to be able to read
files that are read correctly by others. That is the reason I posted that
patch to osg-submissions ...
Greetings
Mathias
--
Dr. Mathias Fröhlich, science + computing ag, Software Solutions
Hagellocher Weg 71-75, D-72070 Tuebingen, Germany
Phone: +49 7071 9457-268, Fax: +49 7071 9457-511
_______________________________________________
osg-users mailing list
[email protected]
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/
