Many thanks Clive!

I have applied this patch to the current version. However see my comments.

Clive Wright wrote:
> Hi,
>
> Drivers for oss_hdaudio and perhaps other soundcards may contain empty 
> groups in their mixer definitions.
>
> This results in empty gtk v/hboxes being displayed in ossxmix which 
> serve no purpose and take up screen space unnecessarily.
>
> The attached patch for ossxmix prevents these empty boxes from being 
> displayed.
>
> I cannot envisage a mixer definition in which the final record would 
> be a mixer group so have not taken any action to prevent i+1 exceeding n.
Actually there may be cases where an empty group is created (which in 
fact may be the last one). Then it will get populated later. So this 
patch may actually caise problems.

This kind of approach is used at least with the new vmix version I'm 
currently working on. It will allocate virtual engines on-demand. So 
initially the mixer interface will have an empty group for the output 
controls (per-application peak meters and volume sliders). Then this 
group will be populated when applications open the audio devices.

Better solution might be to create the widgets for groups as hidden ones 
and to show them at the moment when some content is added to the group. 
This is actually a very trivial change.

Btw, with the new vmix it's possible that new controls get added on fly 
and without notice. This may actually happen rather frequently. So 
ossxmix (and other v4 mixers) should poll SNDCTL_MIX_NREXT once per few 
seconds and to add the new controls to to the GUI whenever it seens 
them. Also this change should be very trivial.

Best regards,

Hannu
_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Reply via email to