On Thursday 05 June 2008 14:03:48 you wrote:
> On 6/5/08, Yair K. <[EMAIL PROTECTED]> wrote:
> >
> > On Thursday 05 June 2008 02:01:32 Zakhar Levchenko wrote:
> > [snip]
> >
> > > I also have attached my own patch to ossxmix that should ignore empty
> > groups
> > > correctly. Could you please try it and see if it solves problems with
> > empty
> > > groups and does not cause any other troubles? It works fine for me, that
> > is
> > > all controls are shown, but I can't check if it ignores empty groups in
> > > practice (though theoretically it should).
> > >
> > > Regards,
> > > Zakhar Levchenko
> > >
> >
> >
> > I don't like the general approach of these patches - they try to hide
> > driver bugs by hacking ossxmix, but everytime a new hack is added it adds
> > complexity (besides, we don't expect other mixer apps to do it?). At least
> > Clive's patch used an #if 1 block which was easily removed.
> >
> > See http://www.fileupyours.com/view/77985/ossxmix-hide.tar.bz2 for an
> > (IMHO) non-hacky idea (admittedly it adds a lot of code) - it lets the user
> > specify widgets that will not be shown (using the ossmix widget name), which
> > can be useful in the general case, but specifically useful for hiding these
> > empty groups. I intend to polish it more (don't poll hidden widgets, add
> > right click menu, add more help to options menu...) before actually
> > submitting it.
> >
> > Yours,
> >
> > Yair K.
> >
>
> Hi,
>
> I agree that such patches as mine or Clive's one are just hacks that are
> intended to work around bugs of particular drivers (hdaudio). But as long as
> such bugs exist we need either to ignore them or work around them. Clive's
> patch is a workaround, my patch is just it's correction.
> We just have two options, two ways:
> 1) Ignore hdaudio bugs, in this case Clive's patch must be completely
> removed and users will have to see empty groups or explicitely hide them
> (after you do what you are working on). Of course, until hdaudio bugs are
> fixed.
> 2) Workaround driver bugs in ossxmix. In this case my patch should replace
> Clive's one because it is much more correct.
>
> I don't mind if we go the first way, but the current state of ossxmix is
> just unacceptable. By the way, I don't see any problems with my patch, it is
> quite simple, straightforward and can be easily removed if needed.
>
> P.S. By the way, why have you sent this letter directly to me, not to
> mailing list? I don't think that such things should be discussed privately.
>
Oops! Used wrong "reply to"...
Yours,
Yair K.
_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
