Hi all, There are some bugs in the current hdaudio driver that may cause empty groups. The driver will create a new group after adding 4 to 8 controls to the group. The purpose of this hack is to prevent the mixer screen from becoming too wide. Unfortunately the driver may after that figure out that none of the remaining controls are connected to anywhere. This will leave unused groups.
One solution might be moving this logic to ossxmix. The driver will create just one group and ossxmix will break it to multiple "lines" if the current box is getting too wide. Would that be implementable? The mixer API is developing to a direction where drivers can create empty groups in advance and the populate them later "on demand". This may cause problems if ossmix just throws away all groups it thinks are empty. It is acceptable if the group h/vboxes are not shown until soimething is created inside them. Best regards, Hannu Yair K. wrote: > On Thursday 05 June 2008 14:03:48 you wrote: > >> On 6/5/08, Yair K. <[EMAIL PROTECTED]> wrote: >> >>> On Thursday 05 June 2008 02:01:32 Zakhar Levchenko wrote: >>> [snip] >>> >>> >>>> I also have attached my own patch to ossxmix that should ignore empty >>>> >>> groups >>> >>>> correctly. Could you please try it and see if it solves problems with >>>> >>> empty >>> >>>> groups and does not cause any other troubles? It works fine for me, that >>>> >>> is >>> >>>> all controls are shown, but I can't check if it ignores empty groups in >>>> practice (though theoretically it should). >>>> >>>> Regards, >>>> Zakhar Levchenko >>>> >>>> >>> I don't like the general approach of these patches - they try to hide >>> driver bugs by hacking ossxmix, but everytime a new hack is added it adds >>> complexity (besides, we don't expect other mixer apps to do it?). At least >>> Clive's patch used an #if 1 block which was easily removed. >>> >>> See http://www.fileupyours.com/view/77985/ossxmix-hide.tar.bz2 for an >>> (IMHO) non-hacky idea (admittedly it adds a lot of code) - it lets the user >>> specify widgets that will not be shown (using the ossmix widget name), which >>> can be useful in the general case, but specifically useful for hiding these >>> empty groups. I intend to polish it more (don't poll hidden widgets, add >>> right click menu, add more help to options menu...) before actually >>> submitting it. >>> >>> Yours, >>> >>> Yair K. >>> >>> >> Hi, >> >> I agree that such patches as mine or Clive's one are just hacks that are >> intended to work around bugs of particular drivers (hdaudio). But as long as >> such bugs exist we need either to ignore them or work around them. Clive's >> patch is a workaround, my patch is just it's correction. >> We just have two options, two ways: >> 1) Ignore hdaudio bugs, in this case Clive's patch must be completely >> removed and users will have to see empty groups or explicitely hide them >> (after you do what you are working on). Of course, until hdaudio bugs are >> fixed. >> 2) Workaround driver bugs in ossxmix. In this case my patch should replace >> Clive's one because it is much more correct. >> >> I don't mind if we go the first way, but the current state of ossxmix is >> just unacceptable. By the way, I don't see any problems with my patch, it is >> quite simple, straightforward and can be easily removed if needed. >> >> P.S. By the way, why have you sent this letter directly to me, not to >> mailing list? I don't think that such things should be discussed privately. >> >> > Oops! Used wrong "reply to"... > > Yours, > Yair K. > _______________________________________________ > oss-devel mailing list > oss-devel@mailman.opensound.com > http://mailman.opensound.com/mailman/listinfo/oss-devel > _______________________________________________ oss-devel mailing list oss-devel@mailman.opensound.com http://mailman.opensound.com/mailman/listinfo/oss-devel
