Third time's the charm. Is PR #821 ok?

On Monday, May 2, 2016 at 4:15:55 PM UTC+2, dan (ddpbsd) wrote:
>
> On Mon, May 2, 2016 at 10:12 AM, Robert Micallef <rober...@gmail.com 
> <javascript:>> wrote: 
> > I'm sorry about that. I never used github before. I didn't know P and h 
> are 
> > incompatible for OpenBSD. But I think the rule should still work by just 
> > modifying <match>. 
> > 
>
> No worries, we'll figure it all out. 
>
> > So how can I fix the PR? Do I close it and try opening it again? I 
> cannot 
> > find where to edit anything apart from the title. 
> > 
>
> I'm not sure, but I'd probably close it and open a new one against MASTER. 
>
> > On Monday, May 2, 2016 at 4:02:08 PM UTC+2, dan (ddpbsd) wrote: 
> >> 
> >> On Mon, May 2, 2016 at 9:57 AM, Robert Micallef <rober...@gmail.com> 
> >> wrote: 
> >> > Hi Dan, 
> >> > 
> >> > Created PR #819. I hope I chose the correct branches.. 
> >> > 
> >> 
> >> Thanks for submitting that, but I left a comment in the PR. New 
> >> changes should be against MASTER, and the "h" and "P" flags are 
> >> incompatible together on OpenBSD. 
> >> 
> >> > -- 
> >> > 
> >> > --- 
> >> > You received this message because you are subscribed to the Google 
> >> > Groups 
> >> > "ossec-list" group. 
> >> > To unsubscribe from this group and stop receiving emails from it, 
> send 
> >> > an 
> >> > email to ossec-list+...@googlegroups.com. 
> >> > For more options, visit https://groups.google.com/d/optout. 
> > 
> > -- 
> > 
> > --- 
> > You received this message because you are subscribed to the Google 
> Groups 
> > "ossec-list" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an 
> > email to ossec-list+...@googlegroups.com <javascript:>. 
> > For more options, visit https://groups.google.com/d/optout. 
>

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"ossec-list" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ossec-list+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to