Thanks Ben, you are right. I was reading the test specification incorrectly. In 
fact, the code is working perfectly (evidence in the log file), it's my test 
procedure that's at fault.

I'll shut up now after thanking both you and Jarno for the previous patch!

Tony
________________________________________
From: Ben Pfaff <b...@ovn.org>
Sent: Friday, 2 December 2016 12:51 p.m.
To: Tony van der Peet
Cc: Jarno Rajahalme; d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS 
flag in flow modify message.

On Thu, Dec 01, 2016 at 09:37:19PM +0000, Tony van der Peet wrote:
> I will foreshadow another problem I found while implementing test
> suite 140. This is where flow is created without SEND_FLOW_REM flag,
> but flow delete does set this bit. The flow removed message is not
> sent in this case. I can see a similar solution to the current patch
> working equally effectively. I'll review Jarno's test cases and try to
> come up with a similarly comprehensive set for this new case.

This is some kind of new interpretation of how flags work.
Historically, flags are set only when a flow is added.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to