Thanks for the patch! It looks good as an initial point that we can add more complexity in the future :).
One personal preference would be to use the string Rtl* functions: https://msdn.microsoft.com/en-us/library/windows/hardware/ff563642(v=vs.85).aspx https://msdn.microsoft.com/en-us/library/windows/hardware/ff563644(v=vs.85).aspx Some white space issues: ../ovs-dev-3-4-datapath-windows-Conntrack---Introduce-support-for-tracking-related-connections.patch:591: new blank line at EOF. + warning: 1 line adds whitespace errors. Other small comments inlined. > -----Original Message----- > From: [email protected] [mailto:ovs-dev- > [email protected]] On Behalf Of Sairam Venugopal > Sent: Thursday, December 1, 2016 11:19 PM > To: [email protected] > Subject: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce > support for tracking related connections > > Introduce a new table to track related connections. This table will be used to > track FTP data connections based on the control connection. There is a new > Conntrack-ftp.c to parse incoming FTP messages to determine the related > data ports. It creates a new entry in the related connections tracker table. > If > there is a matching FTP data connection, then the state for that connection is > marked as RELATED. > > Signed-off-by: Sairam Venugopal <[email protected]> > --- -------------------------------->cut<-------------------------- > + /* End of FTP response is either ) or \r\n */ [Alin Serdean] Check for \n as well. > + if (*buf == ')' || *buf == '\r') { -------------------------------->cut<-------------------------- [Alin Serdean] Maybe add define for 227 (Passive mode) and the comment above in the define. > + if ((len >= 4) && (OvsStrncmp("227", ftpMsg, 3) == 0)) { > + ftpType = FTP_TYPE_PASV; > + /* There are various formats for PASV command. We try to support > + * some of them. This has been addressed by RFC 2428 - EPSV. > + * Eg: > + * 227 Entering Passive Mode (h1,h2,h3,h4,p1,p2).[Alin > Serdean] > + * 227 Entering Passive Mode (h1,h2,h3,h4,p1,p2 > + * 227 Entering Passive Mode. h1,h2,h3,h4,p1,p2 > + * 227 =h1,h2,h3,h4,p1,p2 > + */ -------------------------------->cut<-------------------------- > +VOID > +OvsCleanupCtRelated (VOID) [Alin Serdean] Extra " " character. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
