I will look into using it in a different patch. My main concern is with OvsParseTcp¹s usage of the POVS_PACKET_HDR_INFO.
This field is not passed around and there are cases where the POVS_PACKET_HDR_INFO isn¹t set completely. Eg: l4Payload is set only in User.c context and not in PacketParser.c Thanks, Sairam On 12/5/16, 8:02 AM, "Alin Serdean" <[email protected]> wrote: >Thanks for the patch. > >Looks good. > >I was wondering if we could adapt and reuse OvsParseTcp >(https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswit >ch_ovs_blob_master_datapath-2Dwindows_ovsext_PacketParser.c-23L178&d=DgIFA >g&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m >=8lMHr809OCqFdjrLOCqcntgZXzCe1z0d-sI5uLNV5O8&s=BirXpx4vimliq7cQWh5JdGFDd66 >utMikO5t2tdj_ZFc&e= ) instead? > >Thanks, >Alin. > >> -----Original Message----- >> From: [email protected] [mailto:ovs-dev- >> [email protected]] On Behalf Of Sairam Venugopal >> Sent: Thursday, December 1, 2016 11:19 PM >> To: [email protected] >> Subject: [ovs-dev] [PATCH 1/4] datapath-windows: Conntrack - Fix >> OvsGetTcpPayloadLength() >> >> Move the OvsGetTcpPayloadLength() to common header. Update the code >> to check for null references and the correct size of the TCP header. >> >> Signed-off-by: Sairam Venugopal <[email protected]> >> --- >> datapath-windows/ovsext/Conntrack-tcp.c | 15 --------------- >> datapath-windows/ovsext/Conntrack.h | 22 ++++++++++++++++++++++ >> 2 files changed, 22 insertions(+), 15 deletions(-) >> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
