On 1 Jul 2026, at 15:58, Eli Britstein wrote:

> From: Ariel Levkovich <[email protected]>
>
> Add a new option to build ovs with doca by specifying '--with-doca' in the
> configure line.
>
> This flag must be used along with '--with-dpdk', otherwise the configure
> step will fail.
>
> An example:
>
> ./configure --prefix=/usr --localstatedir=/var --sysconfdir=/etc \
>     --with-dpdk=static --with-doca
>
> The link type follows the selected dpdk one.
>
> Co-authored-by: Salem Sol <[email protected]>
> Signed-off-by: Salem Sol <[email protected]>
> Co-authored-by: Eli Britstein <[email protected]>
> Signed-off-by: Eli Britstein <[email protected]>
> Signed-off-by: Ariel Levkovich <[email protected]>

Thanks, Eli, for this new revision.  I found one small nit;
the rest looks good to me.  However, we might need to revisit
the acinclude.m4 changes once the shared library split patch
is accepted.

Cheers,

Eelco

[...]

> diff --git a/.github/workflows/build-and-test.yml 
> b/.github/workflows/build-and-test.yml
> index aecdfb4df..a02ebb20e 100644
> --- a/.github/workflows/build-and-test.yml
> +++ b/.github/workflows/build-and-test.yml
> @@ -11,7 +11,9 @@ jobs:
>        matrix:
>          runner: [ubuntu-24.04]
>      env:
> -      dependencies: gcc libnuma-dev libxdp-dev ninja-build pkgconf
> +      dependencies: >
> +        gcc libbpf-dev libibverbs-dev libnuma-dev libxdp-dev ninja-build 
> pkgconf
> +        rdma-core
>        CC: gcc
>        DPDK_GIT: https://dpdk.org/git/dpdk
>        DPDK_VER: refs/heads/main
> @@ -66,6 +68,7 @@ jobs:
>      - name: update APT cache
>        if: steps.dpdk_cache.outputs.cache-hit != 'true'
>        run:  sudo apt update || true
> +
>      - name: install common dependencies
>        if: steps.dpdk_cache.outputs.cache-hit != 'true'
>        run:  sudo apt install -y ${{ env.dependencies }}
> @@ -136,8 +139,9 @@ jobs:
>      needs: [build-dpdk, build-libreswan]
>      env:
>        dependencies: |
> -        automake libtool gcc bc libjemalloc2 libjemalloc-dev libssl-dev \
> -        llvm-dev libnuma-dev selinux-policy-dev libxdp-dev lftp
> +        automake bc gcc libbpf-dev libibverbs-dev libjemalloc-dev 
> libjemalloc2 \
> +        libnuma-dev libssl-dev libxdp-dev lftp llvm-dev rdma-core \
> +        selinux-policy-dev libtool

We should keep this list of dependencies in alphabetical order.

        automake bc gcc lftp libbpf-dev libibverbs-dev \
        libjemalloc-dev libjemalloc2 libnuma-dev libssl-dev \
        libtool libxdp-dev llvm-dev rdma-core \
        selinux-policy-dev

>        CC:          ${{ matrix.compiler }}
>        DPDK:        ${{ matrix.dpdk }}
>        DPDK_SHARED: ${{ matrix.dpdk_shared }}

[...]

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to