On 21/07/2026 17:48, Eelco Chaudron wrote:
+
+void netdev_dpdk_mempool_init(const struct smap *ovs_other_config);
+int netdev_dpdk_mempool_full(const struct rte_mempool *mp);
Should this have the OVS_REQUIRES(dpdk_mp_mutex) annotation (and in the
function definition)?
Same for the other functions that have annotations in the
.c file but not in the header declaration:
netdev_dpdk_detect_hw_ol_features OVS_REQUIRES(common->mutex)
netdev_dpdk_get_config_common OVS_REQUIRES(common->mutex)
netdev_dpdk_get_eth_dev_status OVS_EXCLUDED(dpdk_common_mutex, ...)
netdev_dpdk_get_xstat_name OVS_REQUIRES(common->mutex)
netdev_dpdk_lookup_common_by_port_id OVS_REQUIRES(dpdk_common_mutex)
netdev_dpdk_set_dev_etheraddr OVS_REQUIRES(common->mutex)
netdev_dpdk_set_rxq_config OVS_REQUIRES(common->mutex)
Those are already OK. Where do you see an issue?
I added OVS_EXCLUDED to the new mempool functions.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
