On 26 Jul 2026, at 15:28, Eli Britstein wrote:
> On 21/07/2026 13:55, Eelco Chaudron wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> Hi Eli,
>>
>> One more thing I forgot to mention in my earlier review of this
>> patch.
>>
>> //Eelco
>>
>>> + PADDED_MEMBERS(CACHE_LINE_SIZE,
>>> + struct netdev_stats stats;
>>> + struct netdev_dpdk_sw_stats *sw_stats;
>>> + rte_spinlock_t stats_lock;
>>> + );
>> sw_stats is not used by doca; should we keep it in the common
>> structure? Looking at the later patches, doca has its own
>> struct netdev_doca_tx_stats with different fields. Should we
>> move sw_stats out of common and into netdev_dpdk, or use a
>> void *sw_stats so each type can provide its own?
> It is used. netdev_doca_tx_stats is something else.
Guess I looked at to much code an I got confused :(
>> On 21 Jul 2026, at 12:33, Eelco Chaudron wrote:
>>
>>> On 1 Jul 2026, at 15:58, Eli Britstein wrote:
>>>
>>>> As a pre-step towards introducing netdev-doca, that has common parts
>>>> with netdev-dpdk, refactor declarations to be non-static, declared in a
>>>> new file netdev-dpdk-common.h.
>>>>
>>>> Signed-off-by: Eli Britstein <[email protected]>
>>> Hi Eli,
>>>
>>> Thanks for the new revision; some small comments below.
>>>
>>> //Eelco
>> [...]
>>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
