On 07/17/2017 11:23 AM, Darrell Ball wrote:


On 7/17/17, 10:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of 
gvrose8...@gmail.com" <ovs-dev-boun...@openvswitch.org on behalf of 
gvrose8...@gmail.com> wrote:

     From: Greg Rose <gvrose8...@gmail.com>
Add a new test for the kernel module datapath to test if the
     conntrack force direction change and commit is working correctly.

Although the kind of problem that the associated code fix
https://patchwork.ozlabs.org/patch/789646/
addresses is specifically related to kernel conntrack, the test added covers 
both kernel and
userspace conntrack and runs on both.
You may want to update the above text accordingly.

I did not know that.

I can send a V2 or Joe can fix before pushing.  Either way is fine by me.

Thanks,

- Greg


Otherwise
Acked-by: Darrell Ball <dlu...@gmail.com>


     This test was used to find and root cause BZ 18090854.
Signed-off-by: Joe Stringer <j...@ovn.org>
     Signed-off-by: Greg Rose <gvrose8...@gmail.com>
     ---
      tests/system-traffic.at | 12 +++++++++++-
      1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
     index b2393f5..e83ad3a 100644
     --- a/tests/system-traffic.at
     +++ b/tests/system-traffic.at
     @@ -789,7 +789,7 @@ ADD_VETH(p1, at_ns1, br0, "10.1.1.2/24")
      AT_DATA([flows.txt], [dnl
      priority=1,action=drop
      priority=10,arp,action=normal
     -priority=100,in_port=1,udp,action=ct(commit),controller
     +priority=100,in_port=1,udp,action=ct(force,commit),controller
      priority=100,in_port=2,ct_state=-trk,udp,action=ct(table=0)
      
priority=100,in_port=2,ct_state=+trk+est,udp,action=ct(force,commit,table=1)
      table=1,in_port=2,ct_state=+trk,udp,action=controller
     @@ -826,6 +826,16 @@ AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 
"orig=.src=10\.1\.1\.2,"], [],
      
udp,orig=(src=10.1.1.2,dst=10.1.1.1,sport=2,dport=1),reply=(src=10.1.1.1,dst=10.1.1.2,sport=1,dport=2)
      ])
+ovs-appctl vlog/set dpif:dbg
     +
     +dnl OK, now send another packet from port 1 and see that it switches again
     +AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=1 
packet=50540000000a50540000000908004500001c000000000011a4cd0a0101010a0101020001000200080000
 actions=resubmit(,0)"])
     +AT_CHECK([ovs-appctl revalidator/purge], [0])
     +
     +AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 
"orig=.src=10\.1\.1\.1,"], [], [dnl
     
+udp,orig=(src=10.1.1.1,dst=10.1.1.2,sport=1,dport=2),reply=(src=10.1.1.2,dst=10.1.1.1,sport=2,dport=1)
     +])
     +
      OVS_TRAFFIC_VSWITCHD_STOP
      AT_CLEANUP
--
     1.8.3.1
_______________________________________________
     dev mailing list
     d...@openvswitch.org
     
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=OmRby7ktw0_CALnQ5BN7FdkzgJLCpKz0O35RfqlLF4c&s=EjvudY4kKjqWHrvab87oT8u-YWKYhqmjH82JBcAK8gE&e=

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to