On 07/17/2017 12:35 PM, Joe Stringer wrote:
On 17 July 2017 at 12:27, Darrell Ball <[email protected]> wrote:
>
>
> On 7/17/17, 11:26 AM, "Greg Rose" <[email protected]> wrote:
>
>      On 07/17/2017 11:23 AM, Darrell Ball wrote:
>      >
>      >
>      > On 7/17/17, 10:44 AM, "[email protected] on behalf of 
[email protected]" <[email protected] on behalf of [email protected]> 
wrote:
>      >
>      >      From: Greg Rose <[email protected]>
>      >
>      >      Add a new test for the kernel module datapath to test if the
>      >      conntrack force direction change and commit is working correctly.
>      >
>      > Although the kind of problem that the associated code fix
>      > 
https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_789646_&d=DwICaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=n3KZl3lnE-vdWgXO9q3zBE7yv11YOv51N2FWOarYEbk&s=0eYyRkq_xYLqcz617OlfxQ_vR4MDvowvLfPUwLf0C5U&e=
>      > addresses is specifically related to kernel conntrack, the test added 
covers both kernel and
>      > userspace conntrack and runs on both.
>      > You may want to update the above text accordingly.
>
>      I did not know that.
>
>      I can send a V2 or Joe can fix before pushing.  Either way is fine by me.
>
>      Thanks,
>
>      - Greg
>
> same here
>
> The test command for the userspace side is:
>
> dball@ubuntu:~/openvswitch/ovs$ sudo make check-system-userspace 
TESTSUITEFLAGS='19' -C _gcc
> [sudo] password for dball:
> make: Entering directory `/home/dball/openvswitch/ovs/_gcc'
> make  all-recursive
> make[1]: Entering directory `/home/dball/openvswitch/ovs/_gcc'
> Making all in datapath
> make[2]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> Making all in linux
> make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath/linux'
> make -C /lib/modules/3.19.0-25-generic/build 
M=/home/dball/openvswitch/ovs/_gcc/datapath/linux modules
> make[4]: Entering directory `/usr/src/linux-headers-3.19.0-25-generic'
>    Building modules, stage 2.
>    MODPOST 6 modules
> make[4]: Leaving directory `/usr/src/linux-headers-3.19.0-25-generic'
> make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath/linux'
> make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> make[2]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> make[2]: Entering directory `/home/dball/openvswitch/ovs/_gcc'
> make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> make[3]: `distfiles' is up to date.
> make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> make[2]: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
> make[1]: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
> set /bin/bash '../tests/system-userspace-testsuite' -C tests  
AUTOTEST_PATH='utilities:vswitchd:ovsdb:vtep:tests::ovn/controller-vtep:ovn/northd:ovn/utilities:ovn/controller'
 19 -j1; \
>          "$@" || (test X'' = Xyes && "$@" --recheck)
> ## ------------------------------ ##
> ## openvswitch 2.7.90 test suite. ##
> ## ------------------------------ ##
>   19: conntrack - force commit                        ok
>
> ## ------------- ##
> ## Test results. ##
> ## ------------- ##
>
> 1 test was successful.
> make: Leaving directory `/home/dball/openvswitch/ovs/_gcc'

Thanks for trying it out. I'll hold off on applying this until we get
the kernel side in.

Dave Miller applied the upstream kernel patch.

See attachment.

Just FYI as I'm not sure who follows netdev.

Thanks,

- Greg
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to