On 7/17/17, 11:26 AM, "Greg Rose" <[email protected]> wrote:
On 07/17/2017 11:23 AM, Darrell Ball wrote:
>
>
> On 7/17/17, 10:44 AM, "[email protected] on behalf of
[email protected]" <[email protected] on behalf of
[email protected]> wrote:
>
> From: Greg Rose <[email protected]>
>
> Add a new test for the kernel module datapath to test if the
> conntrack force direction change and commit is working correctly.
>
> Although the kind of problem that the associated code fix
>
https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_789646_&d=DwICaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=n3KZl3lnE-vdWgXO9q3zBE7yv11YOv51N2FWOarYEbk&s=0eYyRkq_xYLqcz617OlfxQ_vR4MDvowvLfPUwLf0C5U&e=
> addresses is specifically related to kernel conntrack, the test added
covers both kernel and
> userspace conntrack and runs on both.
> You may want to update the above text accordingly.
I did not know that.
I can send a V2 or Joe can fix before pushing. Either way is fine by me.
Thanks,
- Greg
same here
The test command for the userspace side is:
dball@ubuntu:~/openvswitch/ovs$ sudo make check-system-userspace
TESTSUITEFLAGS='19' -C _gcc
[sudo] password for dball:
make: Entering directory `/home/dball/openvswitch/ovs/_gcc'
make all-recursive
make[1]: Entering directory `/home/dball/openvswitch/ovs/_gcc'
Making all in datapath
make[2]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
Making all in linux
make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath/linux'
make -C /lib/modules/3.19.0-25-generic/build
M=/home/dball/openvswitch/ovs/_gcc/datapath/linux modules
make[4]: Entering directory `/usr/src/linux-headers-3.19.0-25-generic'
Building modules, stage 2.
MODPOST 6 modules
make[4]: Leaving directory `/usr/src/linux-headers-3.19.0-25-generic'
make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath/linux'
make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
make[2]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
make[2]: Entering directory `/home/dball/openvswitch/ovs/_gcc'
make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
make[3]: `distfiles' is up to date.
make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
make[2]: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
make[1]: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
set /bin/bash '../tests/system-userspace-testsuite' -C tests
AUTOTEST_PATH='utilities:vswitchd:ovsdb:vtep:tests::ovn/controller-vtep:ovn/northd:ovn/utilities:ovn/controller'
19 -j1; \
"$@" || (test X'' = Xyes && "$@" --recheck)
## ------------------------------ ##
## openvswitch 2.7.90 test suite. ##
## ------------------------------ ##
19: conntrack - force commit ok
## ------------- ##
## Test results. ##
## ------------- ##
1 test was successful.
make: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
>
> Otherwise
> Acked-by: Darrell Ball <[email protected]>
>
>
> This test was used to find and root cause BZ 18090854.
>
> Signed-off-by: Joe Stringer <[email protected]>
> Signed-off-by: Greg Rose <[email protected]>
> ---
> tests/system-traffic.at | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
> index b2393f5..e83ad3a 100644
> --- a/tests/system-traffic.at
> +++ b/tests/system-traffic.at
> @@ -789,7 +789,7 @@ ADD_VETH(p1, at_ns1, br0, "10.1.1.2/24")
> AT_DATA([flows.txt], [dnl
> priority=1,action=drop
> priority=10,arp,action=normal
> -priority=100,in_port=1,udp,action=ct(commit),controller
> +priority=100,in_port=1,udp,action=ct(force,commit),controller
> priority=100,in_port=2,ct_state=-trk,udp,action=ct(table=0)
>
priority=100,in_port=2,ct_state=+trk+est,udp,action=ct(force,commit,table=1)
> table=1,in_port=2,ct_state=+trk,udp,action=controller
> @@ -826,6 +826,16 @@ AT_CHECK([ovs-appctl dpctl/dump-conntrack |
grep "orig=.src=10\.1\.1\.2,"], [],
>
udp,orig=(src=10.1.1.2,dst=10.1.1.1,sport=2,dport=1),reply=(src=10.1.1.1,dst=10.1.1.2,sport=1,dport=2)
> ])
>
> +ovs-appctl vlog/set dpif:dbg
> +
> +dnl OK, now send another packet from port 1 and see that it
switches again
> +AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=1
packet=50540000000a50540000000908004500001c000000000011a4cd0a0101010a0101020001000200080000
actions=resubmit(,0)"])
> +AT_CHECK([ovs-appctl revalidator/purge], [0])
> +
> +AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep
"orig=.src=10\.1\.1\.1,"], [], [dnl
>
+udp,orig=(src=10.1.1.1,dst=10.1.1.2,sport=1,dport=2),reply=(src=10.1.1.2,dst=10.1.1.1,sport=2,dport=1)
> +])
> +
> OVS_TRAFFIC_VSWITCHD_STOP
> AT_CLEANUP
>
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> [email protected]
>
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=OmRby7ktw0_CALnQ5BN7FdkzgJLCpKz0O35RfqlLF4c&s=EjvudY4kKjqWHrvab87oT8u-YWKYhqmjH82JBcAK8gE&e=
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
