On 12/05/2017 02:55 PM, Michal Weglicki wrote: > - New get_custom_stats interface function is added to netdev. It > allows particular netdev implementation to expose custom > counters in dictionary format (counter name/counter value). > - New statistics are retrieved using experimenter code and > are printed as a result to ofctl dump-ports. > - New counters are available for OpenFlow 1.4+. > - New statistics are printed to output via ofctl only if those > are present in reply message. > - New statistics definition is added to include/openflow/intel-ext.h. > - Custom statistics are implemented only for dpdk-physical > port type. > - DPDK-physical implementation uses xstats to collect statistics. > Only dropped and error counters are exposed. >
Hi Michal - why only dropped and error counters? why not just expose them all. For example, IIUC this would report management dropped packets but there would not be a stat for management rx/tx successful packets. Kevin. > v1->v2: > - Buffer overrun check in parse_intel_port_custom_property. > - ofputil_append_ofp14_port_stats uses "postappend" instead > of "reserve" during message creation. > - NEWS update. > - DPDK documentation update. > - Compilation and sparse warnings corrections. > > Signed-off-by: Michal Weglicki <michalx.wegli...@intel.com> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
