> -----Original Message----- > From: Kevin Traynor [mailto:[email protected]] > Sent: Tuesday, December 19, 2017 3:07 PM > To: Weglicki, MichalX <[email protected]>; [email protected] > Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics. > > On 12/05/2017 02:55 PM, Michal Weglicki wrote: > > - New get_custom_stats interface function is added to netdev. It > > allows particular netdev implementation to expose custom > > counters in dictionary format (counter name/counter value). > > - New statistics are retrieved using experimenter code and > > are printed as a result to ofctl dump-ports. > > - New counters are available for OpenFlow 1.4+. > > - New statistics are printed to output via ofctl only if those > > are present in reply message. > > - New statistics definition is added to include/openflow/intel-ext.h. > > - Custom statistics are implemented only for dpdk-physical > > port type. > > - DPDK-physical implementation uses xstats to collect statistics. > > Only dropped and error counters are exposed. > > > > Hi Michal - why only dropped and error counters? why not just expose > them all. For example, IIUC this would report management dropped packets > but there would not be a stat for management rx/tx successful packets. > > Kevin.
Hi Kevin - those counters were of biggest value to us at the point of making this patch, sending all counters (where for IXGBE is about 150) will produce some movement on the network. I think that biggest advantage of this particular patch is that it introduces a mechanism to expose any counters, counters list can be extended in the future if necessary. However I'm not sure if sending all counters is good idea, as there could be thousands of it in the future - in this solution, we have some kind of control over the data size. Michal. > > > v1->v2: > > - Buffer overrun check in parse_intel_port_custom_property. > > - ofputil_append_ofp14_port_stats uses "postappend" instead > > of "reserve" during message creation. > > - NEWS update. > > - DPDK documentation update. > > - Compilation and sparse warnings corrections. > > > > Signed-off-by: Michal Weglicki <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
